Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Upgrade Vitest to 1.6.0 #28711

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Build: Upgrade Vitest to 1.6.0 #28711

merged 1 commit into from
Jul 25, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 25, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 0 B -1.13 0%
initSize 198 MB 198 MB -9.99 kB -1.3 0%
diffSize 121 MB 121 MB -9.99 kB -7.8 0%
buildSize 7.6 MB 7.6 MB 0 B - 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B - 0%
buildSbPreviewSize 349 kB 349 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB 0 B - 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B - 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 14.2s 23.4s 9.2s 1.09 39.4%
generateTime 22.2s 22.1s -59ms -0.15 -0.3%
initTime 20.8s 24s 3.1s 0.44 13.3%
buildTime 13.7s 12.6s -1s -84ms -1.72 🔰-8.6%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 9.1s 9.6s 560ms 0.51 5.8%
devManagerResponsive 6.3s 6.6s 301ms 1.3 4.5%
devManagerHeaderVisible 885ms 934ms 49ms 0.32 5.2%
devManagerIndexVisible 933ms 988ms 55ms 0.44 5.6%
devStoryVisibleUncached 1.2s 1.3s 65ms -0.46 5%
devStoryVisible 955ms 1s 58ms 0.43 5.7%
devAutodocsVisible 887ms 817ms -70ms 0.03 -8.6%
devMDXVisible 795ms 842ms 47ms 0.6 5.6%
buildManagerHeaderVisible 1s 1.1s 91ms 1.68 🔺8.2%
buildManagerIndexVisible 1s 1.1s 99ms 1.71 🔺8.9%
buildStoryVisible 1s 1.1s 94ms 1.69 🔺8%
buildAutodocsVisible 894ms 896ms 2ms 0.81 0.2%
buildMDXVisible 815ms 813ms -2ms 0.44 -0.2%

@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Jul 25, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Upgraded Vitest to version 1.6.0 to leverage new features, improvements, and bug fixes.

  • Updated code/package.json to upgrade vitest from 1.2.2 to 1.6.0.
  • Updated test-storybooks/portable-stories-kitchen-sink/svelte/package.json to upgrade vitest from ^1.3.1 to ^1.6.0.

Ensure all tests pass and verify compatibility with other dependencies.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5f80a63. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf merged commit 1633942 into next Jul 25, 2024
53 of 54 checks passed
@yannbf yannbf deleted the yann/upgrade-vitest-v1 branch July 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants